Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag create: respect created_date and created_id params #17257

Merged
merged 1 commit into from
May 10, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 7, 2020

Overview

Cleans up the Tag BAO to use more modern patterns and ensures that the created_date and created_id params are respected.

Before

Params ignored. Performs an extra find() lookup even for newly created tags.

After

Params not ignored. Restricted find() to existing tags for efficiency. Removed old pass-by-ref stuff.

@civibot civibot bot added the master label May 7, 2020
@civibot
Copy link

civibot bot commented May 7, 2020

(Standard links)

@colemanw colemanw force-pushed the tagParam branch 5 times, most recently from b7a5bb2 to 4cc42e7 Compare May 7, 2020 21:20
@seamuslee001
Copy link
Contributor

looks like test fails relate @colemanw

@colemanw
Copy link
Member Author

colemanw commented May 8, 2020

@seamuslee001 fixed

@mattwire mattwire merged commit b3e7633 into civicrm:master May 10, 2020
@colemanw colemanw deleted the tagParam branch May 10, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants