Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1742 Expose CiviCRM Database details for views configuration… #17232

Merged
merged 1 commit into from
May 5, 2020

Conversation

seamuslee001
Copy link
Contributor

… in Drupal 8 as well as in Drupal 7 and Backdrop

Overview

This exposes the necessary database configuration needed to be added to settings.php for views to work with CiviCRM tables when CiviCRM is in a different schema for Drupal 8 as well as Drupal 7 and Backdrop

Before

Views DB config only showing on Drupal 7 and Backdrop

After

Views DB config shows on Drupal 8/7 and Backdrop

ping @MikeyMJCO @jackrabbithanna

… in Drupal 8 as well as in Drupal 7 and Backdrop
@civibot
Copy link

civibot bot commented May 5, 2020

(Standard links)

@civibot civibot bot added the master label May 5, 2020
@homotechsual
Copy link
Contributor

homotechsual commented May 5, 2020

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) PASS
    • (r-user) PASS: This restores expected behaviour on D8/Backdrop.
    • (r-doc) PASS: Docs not required.
    • (r-run) PASS: Behaves correctly on D8 and Backdrop test sites.
  • Developer standards

Drupal 8

Backdrop

@homotechsual
Copy link
Contributor

One question/observation - is that syntax correct for Backdrop, that's the Drupal 6 style syntax for additional tables, my understanding is that Backdrop uses the Drupal 7 style (same as D8).

@seamuslee001
Copy link
Contributor Author

@MikeyMJCO looks like it is correct https://api.backdropcms.org/database-configuration

@homotechsual
Copy link
Contributor

@MikeyMJCO looks like it is correct https://api.backdropcms.org/database-configuration

Okay :-)

@eileenmcnaughton
Copy link
Contributor

Code looks good - merging based on @MikeyMJCO's review

@eileenmcnaughton eileenmcnaughton merged commit cbef5d2 into civicrm:master May 5, 2020
@eileenmcnaughton eileenmcnaughton deleted the dev_core_1742 branch May 5, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants