Fix adding languages in multilingual

[mattwire]

Overview

Adding or removing a language when multilingual is enabled fails with a DB error. This is because it deletes the "currenciesEnabled" optiongroup and values and then tries to recreate them - but in multilingual this fails because label is a required field in optionvalue for all languages but each language query will try and run a query that adds/updates an entry for it's own language (leaving a required field not set for the other language labels).

Before

Issues adding/removing languages in multilingual.

After

• Languages can be added/removed.
• Updating optionGroup/optionValues now tries to update instead of blindly deleting first.
• currenciesEnabled is only updated AFTER enabling/disabling multilingual - it doesn't make sense to try to do this before.

Technical Details

We use the DAO find() method to find existing optiongroup/values and update them.

Comments

@mlutfy @aydun @MikeyMJCO Testing welcome :-)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jaapjansma]

test this please

[jaapjansma]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: We have run it in both dmaster and in the test environment of this pr.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change is trivial enough that it does not require tests.
    • COMMENT: I dont think this needs a test but a test might be helpful to detect if this breaks again in the future. So a test would have been a surplus but it is not blocking our advice of merging this PR.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@eileenmcnaughton or @colemanw could one of you merge this PR?

[mlutfy]

Thanks @mattwire and @jaapjansma for reviewing.

I'm a bit surprised that the test coverage did not catch this, since we do have tests for multilingual?

[eileenmcnaughton]

note this caused a regression which is partially fixed in #20627