[REF] Fix retrieving invoice related settings when doing complete tra…

[seamuslee001]

…nsaction

Overview

This fixes a bug that has shown up via test failures on PayPalIPN Tests which is that the invoicing code was mistakenly being run but of course when it does the loadObjects in the Invoice.php file there is no payment_processor_id to speak of and then a fatal error gets set

Before

PayPalIPN tests fail

After

PayPalIPN Tests pass

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

ping @totten @eileenmcnaughton

[totten]

In https://test.civicrm.org/job/CiviCRM-Core-Matrix/, I've seen the failures for PayPalIPNTest on master, but I haven't seen any failures on 5.25 or 5.24.

This PR is targetted at 5.25. Was that just an assumption that 5.25 was affected - or do you believe there's an unreported issue in5.25?

[eileenmcnaughton]

I think the deployed fix should address this - we should do this but I think master may be OK

[eileenmcnaughton]

hmm - I guess failing tests....