Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Don't advertise implicit multi-joins in Explorer #17205

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

colemanw
Copy link
Member

Overview

These joins are problematic and may be removed. The Explorer should not display them.

Before

Now you see them.

After

Now you don't.

Technical Details

This is the first step in deprecation. This doesn't remove support for them, just visibility.

These joins are problematic and may be removed. The Explorer should not display them.
@civibot
Copy link

civibot bot commented Apr 30, 2020

(Standard links)

@civibot civibot bot added the 5.25 label Apr 30, 2020
@colemanw
Copy link
Member Author

@eileenmcnaughton I'd like to get this into 5.25.

@totten
Copy link
Member

totten commented Apr 30, 2020

Policy-wise -- That does seem like a good way to phase it out!

I tried it out on the autobuild site and didn't notice any obvious breakage. The N-to-1 joins (e.g. Contact's current_employer) still showed up. Seems good.

@totten totten added the merge ready PR will be merged after a few days if there are no objections label Apr 30, 2020
@eileenmcnaughton
Copy link
Contributor

OK - I can accept that while this is not an actual regression, this does fix the case for not advertising something that would up not being doable and an rc hit might save some pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.25 merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants