OptionValue - Use DB defaults instead of setting them in BAO::add

[colemanw]

Overview

Relies on DB defaults instead of setting them manually in the BAO.

Before

Setting defaults in PHP.

After

Use defaults set in the DB.

Technical Details

Of the 4 defaults being set in the BAO, 3 already had db defaults; I added DEFAULT NULL for the last.

Comments

The DB default for is_active is 1 but the BAO was setting it to 0. IMO the db default is better.
Existing forms all set this explicitly so this change won't affect them.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton this fixes the test failures in #17167

[eileenmcnaughton]

Looks good to me - I note that this changes the default for is_active - but in a way that is consistent with other places (defaults to TRUE)