Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution id as activity source record when downloading or emailing invoice #17165

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

pradpnayak
Copy link
Contributor

Overview

When a invoice is emailed or downloaded CiviCRM creates activity of type 'Emailed Invoice' or 'Downloaded Invoice' respectively. These activities has missing source record and have no ways to reference to contribution other than viewing the activity , checking the attached invoice to find invoice number and so on.

This PR adds source record as contribution id in activity params so that it can be referenced in future.

Before

Activity source id was set to null for activity type 'Emailed Invoice' or 'Downloaded Invoice'

After

Activity source id was set to contribution id for activity type 'Emailed Invoice' or 'Downloaded Invoice'

@civibot
Copy link

civibot bot commented Apr 24, 2020

(Standard links)

@civibot civibot bot added the master label Apr 24, 2020
@eileenmcnaughton
Copy link
Contributor

Seems OK to me - we should really use apiv4 not 3 but I think we can leave that for now

@eileenmcnaughton eileenmcnaughton merged commit 0b591f3 into civicrm:master Apr 25, 2020
@pradpnayak pradpnayak deleted the ActivitySource branch June 5, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants