[REF] Consistently lookup dispatcher via Civi::dispatcher()
#17154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code standardisation
Before
We have are using 3 ways of getting the dispatcher
Civi\Core\Container::singleton()->get('dispatcher')
Civi::service('dispatcher')
Civi::dispatcher()
Tim confirms there is no functional difference
After
All instances call Civi::dispatcher()
Technical Details
From @totten on chat
"they're the same thing
Civi::dispatcher() is just a little prettier
e.g. the IDE is smarter about completing with ::dispatcher()
historically, ::service(...) was around before ::dispatcher()
and ::service(...) is a more generic facility.
you don't want to add every random little object as new wrapper method in Civi.php, but dispatcher is a really common+central thing"
Comments
From #16983 but I needed to clarify this & so doing did it throughout