Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cc field on emailTrait to use entity reference #17129

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 21, 2020

Overview

Extend #17064 to cc field

Before

cc field uses custom js

After

cc field uses entity reference

Technical Details

Per #17064 - note this only affects the cc field - I have left the to field for now as it will be a bigger code cleanup

Comments

@colemanw

@civibot
Copy link

civibot bot commented Apr 21, 2020

(Standard links)

@colemanw
Copy link
Member

Tested this out and it works great. Nice to see more code removal.
Can't wait for the "To:" field followup and how much code gets deleted there!

@colemanw colemanw merged commit 3b65a28 into civicrm:master Apr 28, 2020
@colemanw colemanw deleted the email2 branch April 28, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants