dev/core#1721 send email to case follow-up activity assignees

[lcdservices]

Overview

When creating a case activity follow-up activity with an assignee, the assignee is not sent an email.

Before

Follow-up assignee does not receive an email.

After

Assignee should receive an email

Technical Details

Assignee email processing is simply missing. This mostly follows the pattern found in CRM_Activity_Form_Activity::processActivity() -- with adaptation to the case context.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks for the PR. This is similar to #16800, so I have the same comments as there, but it's non-blocking.

• General standards
  • [r-explain] PASS
  • [r-user] PASS
    Some people might start getting emails who didn't before, but should be ok.
  • [r-doc] PASS
  • [r-run] PASS
    • Confirmed problem exists before. Works after.
• Developer standards
  • [r-tech] Comment
    The same comment I made on Respect 'Donot notify activity type' setting #16800 that this should be fine for short-term but a better long-term way would be to move it out of the form to a BAO or somewhere central so that it can be consolidated with the regular activity form and then also have the api (and hence webform) use it too when activities are created.
  • [r-code] PASS
    • It ends up not mattering but line 660 should probably be $followupStatus.
  • [r-maint] Undecided
    Also copy/pasting my same comment from the other PR: It's hard to write a test for this but as noted in r-tech I think it should be moved out of the forms, and then that would also make it easier to write a test.
  • [r-test] PASS

[eileenmcnaughton]

I'm going to merge this - @demeritcowboy's concerns about mtce are valid. However, I read the review as it does fix a bug & since it's been 23 days since the review I feel I should make a call based on what has been done