Simplify / Cleanup Contribution BAO create#17115

Closed

mattwire wants to merge 3 commits intocivicrm:masterfrom mattwire:contributionbaofullobject

+30-75

Commits on Apr 27, 2020

Retrieve full contribution object once so we don't have to keep checking if bits are set. Fix bug where retrieve fails if you had passed in an unrounded fee_amount which led to addActivity failing …
mattwire
committed
Fix undefined index on financial_type_id for api_v3_ContributionTest::testSendconfirmationPayLater
mattwire
committed
Fix test results to check actual values that are written to the DB
mattwire
committed