Duplicate EmailCommon::buildQuickForm onto the trait #17052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy EmailCommon::buildQuickForm onto the new trait we are using instead of the static class for shared email form functionality
I have duplicated this code rather than moving it in case any non-core code calls it. We can remove in a bit
Before
buildForm is on the static class - it references many form attributes that are inconsistently defined
After
buildForm is on the trait. The old code remains in the static function with a deprecation notice in case anyone is accessing it in an unsupported way
Technical Details
Comments