Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outputHeader as a param for writeCSVFile as it is always true #17051

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 10, 2020

Overview

Removes a meaningless parameter

Before

public static function writeCSVFile($fileName, $header, $rows, $outputHeader = TRUE)

After

public static function writeCSVFile($fileName, $header, $rows)

Technical Details

The calls to this function do not pass the last parameter

Comments

@civibot
Copy link

civibot bot commented Apr 10, 2020

(Standard links)

@civibot civibot bot added the master label Apr 10, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@demeritcowboy
Copy link
Contributor

This looks ok to me just running a test since it's been a week, which is ages in civi-time. It's possible there's an extension that uses it. I've never downloaded the "fetch universe" - this might be a good one to grep writeCSVFile on and see what comes up. Jenkins test this please.

@mattwire
Copy link
Contributor

I don't quite have the universe locally but I'm close - and I can't see it used anywhere so marking merge on pass based on @demeritcowboy review.

@seamuslee001 seamuslee001 merged commit 0aa61b6 into civicrm:master Apr 17, 2020
@seamuslee001 seamuslee001 deleted the ex branch April 17, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants