Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/report#31 - Api4 Explorer: Support SQL functions and HAVING clause #17047

Merged
merged 7 commits into from
Apr 9, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 9, 2020

Overview

This adds UI support for new APIv4 features. Sql functions and aliases are now available in the API explorer, as is the HAVING clause.

See also: https://lab.civicrm.org/dev/report/-/issues/31

Before

UI didn't show new features.

After

UI updated.

Technical Details

Includes tests for loading SQL function metadata.

@civibot
Copy link

civibot bot commented Apr 9, 2020

(Standard links)

@civibot civibot bot added the master label Apr 9, 2020
@eileenmcnaughton
Copy link
Contributor

Only affects apiv4 explorer so this should be safe

@totten
Copy link
Member

totten commented Apr 9, 2020

r-explain: The descriptions on #17047 and #16947 are rather... thin... given what's going on here. Is there a Gitlab issue or docs PR that should be referenced?

@totten totten changed the title Api4 Explorer: Support SQL functions and HAVING clause dev/report#1 - Api4 Explorer: Support SQL functions and HAVING clause Apr 9, 2020
@totten
Copy link
Member

totten commented Apr 9, 2020

OK, I found+hyperlinked the related Gitlab issue. It doesn't talk much about what's going on here.

Probably most of the r-explain/r-docs problem I'm sensing is more about the earlier PR (#16947). For this PR and the API explorer, one might just do some screenshots of the updated UI...

@totten totten changed the title dev/report#1 - Api4 Explorer: Support SQL functions and HAVING clause dev/report#31 - Api4 Explorer: Support SQL functions and HAVING clause Apr 9, 2020
@eileenmcnaughton
Copy link
Contributor

To some extent the explorer update IS the documentation of the earlier change - however @colemanw you had better also do a docs update on new apiv4 capabilities

Test fail unrelated

@eileenmcnaughton eileenmcnaughton merged commit cc78f78 into civicrm:master Apr 9, 2020
@eileenmcnaughton eileenmcnaughton deleted the api4exp branch April 9, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants