CRM_Core_I18n - Provide a better label for new/unknown locales #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- Suppose you add new/unrecognized data files in the `l10n` folder - and then you navigate to the screen `civicrm/admin/setting/localization?reset=1`. Before ------ The new language appears in the admin UI as a blank item. Every page in the app displays a warning about the unrecognized locale. After ----- The new language appears in the admin UI with a placeholder name (based on the code). The warnings are not displayed. Comment ------- We've just had an issue where a new language was added to the `l10n` data-set, and then all automated test-suites for all versions (incl `5.25` RC and `5.24` stable) started to throw blocker errors on unrelated PRs. This is because the `l10n` data is generally evergreen, but each branch/tag of `civicrm-core` has the list hard-coded in multiple spots. This patch tries to make the symptom less painful when mixing/matching different revisions of `civicrm-core.git` and `l10n.git`.
|
(Standard links)
|
|
This sounds good and it works, and then I can just make the upgrade script against master. I briefly thought maybe it should append the word Pending or Experimental or something so people don't try to edit it but I don't think that would happen often since they'd have to figure out they'd need to add an option value. Oops I just told them. |
|
I'm going to merge this and we can backport this to 5.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mixing the current
l10ndata with a stablecivicrm-corecodebase leads to warnings/failures about the localenl_BE(even if you don't use that locale). This patch aims to makecivicrm-coremore forward-compatible asl10nevolves.Suppose you add data-files for a new language/locale in the
l10nfolder - and then you navigate to the screencivicrm/admin/setting/localization?reset=1. How is this new language presented?Before
The new language appears in the admin UI as a blank item.
Every page in the app displays a warning about the unrecognized locale, even if your system never uses that locale.
When running automated tests, the warning can lead to a large number of false-negatives.
After
The new language appears in the admin UI with a placeholder name (based on the code).
Also, the pervasive warning goes away.
Comment
We've just had an issue where a new language (
nl_BE) was added to thel10ndata-set, and then all automated test-suites for all versions (incl5.25RC and5.24stable) started to throw numerous errors (about the unrecognized locale) on unrelated PRs. The issue is thatl10ndata is generally evergreen (so new languages can be added at anytime), but each branch/tag ofcivicrm-corehas multiple hard-coded language lists (which locks in the list for a given release).Mixing the current
l10nwith a stablecivicrm-coreleads to the warnings/failures. This patch tries to make the symptom less painful when mixing/matching different revisions ofcivicrm-coreandl10n.