dev/financial#84 - Fix upgrade failure. Thin-out activation logic for sequentialcreditnotes.

[totten]

Overview

This fixes an issue with running the upgrade on certain builds. It addresses the problem by reducing the number of services/layers involved with activating the sequentialcreditnotes extension.

Related: https://civicrm.stackexchange.com/a/35260/93

Steps to reproduce

• Create a site based on wp-demo with Civi 5.21
• Make a DB snapshot
• Update code to 5.24
• In the web UI, run the DB upgrade
  • Note: It's important to use the web UI. The problem does not reproduce in CLI.

Before

(1) The upgrader activates sequentialcreditnotes using the Extension.install API

(2) The upgrader freezes on "Upgrade DB to 5.24.alpha1". The CiviCRM.log includes:

Apr 03 14:41:50  [info] Running task: Upgrade DB to 5.24.alpha1: SQL

Apr 03 14:41:55  [info] Running task: Install sequential creditnote extension

Apr 03 14:42:14  [info] $CRM_Queue_ErrorPolicy_reportError = Array
(
    [is_error] => 1
    [is_continue] => 0
    [exception] => Error 1: Uncaught Error: Class 'CRM_Volunteer_Permission' not found in /home/me/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm/tools/extensions/civivolunteer/volunteer.php:497
Stack trace:
0 /home/me/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/Hook.php(286): volunteer_civicrm_permission(Array)
1 /home/me/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/Hook/WordPress.php(139): CRM_Utils_Hook->runHooks(Array, 'civicrm_permiss...', 1, Array, NULL, NULL, NULL, NULL, NULL)
2 /home/me/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm/Civi/Core/CiviEventDispatcher.php(86): CRM_Utils_Hook_WordPress->invokeViaUF(1, Array, NULL, NULL, NULL, NULL, NULL, 'civicrm_permiss...')
3 /home/me/bknix/build/wpmaster/web/wp-content/plugins/civicrm/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(184): Civi\Core\CiviEventDispatcher::delegateToUF(Object(Civi\Core\Event\GenericHookEvent), 'hook_civicrm_p
    [last_task_title] => Install sequential creditnote extension
)

After

(1) The upgrader activates sequentialcreditnotes using a SQL insert.

(2) The upgrade completes. After installation, the sequentialcreditnotes extension is active.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Looks good to me - as our first foray in this direction we are flushing out the pointy bits