dev/core#1682 - Invalid currency on sending offline membership receipt. #16943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
jitendrapurohit
commented
Apr 1, 2020
| @@ -1617,8 +1617,7 @@ public function submit() { | |||
| } | |||
|
|
|||
| if (!empty($lineItem[$this->_priceSetId])) { | |||
| $invoiceSettings = Civi::settings()->get('contribution_invoice_settings'); | |||
| $invoicing = $invoiceSettings['invoicing'] ?? NULL; | |||
There was a problem hiding this comment.
contribution_invoice_settings is a deprecated setting, the correct value of invoicing can be directly obtained from Civi::settings()->get('invoicing');
There was a problem hiding this comment.
@eileenmcnaughton looks like in your sweep missed one
There was a problem hiding this comment.
@seamuslee001 yep - I made it so that still works rather than replacing them all
|
I'm ok with this - tbh the send template code should take care of assigning it's own variables & this should be overwritten. However, this fixes a bug (which doesn't look like a recent regression) and since it's all on the form layer I'm OK....ish ... with no test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix error on offline membership form when receipt checkbox is enabled.
Before
See steps to replicate on gitlab - https://lab.civicrm.org/dev/core/-/issues/1682
After
Fixed.
Technical Details
When the membership form is rendered,
currencyvariable is set to the symbol value to display it on the form. Same value is carried to the message template which errors on translating the amount value with{$amount|crmMoney:$currency}token.Comments
Gitlab - https://lab.civicrm.org/dev/core/-/issues/1682