Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move more code to the trait [WIP] #16936

Closed
wants to merge 10 commits into from
Prev Previous commit
Next Next commit
Remove immediately overwritten value
  • Loading branch information
eileenmcnaughton committed Apr 6, 2020
commit a7491edacc13a1f16e62ecee6a5a16250124aece
1 change: 0 additions & 1 deletion CRM/Contact/Form/Task/EmailTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ protected function bounceIfSimpleMailLimitExceeded($count) {
public function submit($formValues) {
$this->saveMessageTemplate($formValues);

$from = $formValues['from_email_address'] ?? NULL;
// dev/core#357 User Emails are keyed by their id so that the Signature is able to be added
// If we have had a contact email used here the value returned from the line above will be the
// numerical key where as $from for use in the sendEmail in Activity needs to be of format of "To Name" <toemailaddress>
Expand Down