Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] extract code to getEmails #16929

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[REF] extract code to getEmails #16929

merged 1 commit into from
Mar 31, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 31, 2020 •
edited
Loading

Overview

Minor extraction for code readability

Before

More use of variable variables

After

Use of variable variables reduced through extraction

Technical Details

This is awful code! More could be done but this is a step

Comments

@civibot
Copy link

civibot bot commented Mar 31, 2020

(Standard links)

@civibot civibot bot added the master label Mar 31, 2020
@colemanw colemanw merged commit 8742ba9 into civicrm:master Mar 31, 2020
@colemanw colemanw deleted the email2 branch March 31, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw