[REF] Move form specific handling back to the relevant form.

[eileenmcnaughton]

Overview

Moves code specific to one form out of a shared class

Before

Code specific to CRM_Contact_Form_Task_Email is in the shared CRM_Contact_Form_Task_EmailCommon function

After

Code moved back to own form

Technical Details

The shared function has handling to set ->_single if the class is CRM_Contact_Form_Task_Email -
this seems pretty obviously not functionality that is shared so it should be on the CRM_Contact_Form_Task_Email
class

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Change looks fine to me test failure unrelated merging

[mattwire]

A sensible simplification that will make future maintenance easier @kcristiano when testing 5.25 please pay particular attention to sending emails via the UI in various ways - changes to this code has a habit of breaking things is unexpected/obscure ways.