Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] minor form cleanup. #16905

Merged
merged 1 commit into from
Mar 26, 2020
Merged

[NFC] minor form cleanup. #16905

merged 1 commit into from
Mar 26, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Most notably fix calling a non-static method statically but also remove comment that
clearly came in by copy & paste,

Before

calling a non-static method statically, other minor issues

After

Fixed

Technical Details

Comments

@eileenmcnaughton
[NFC] minor form cleanup.
946d8b8 
Most notably  fix calling a non-static method statically but also remove comment that
clearly came in by copy & paste,
@civibot
Copy link

civibot bot commented Mar 26, 2020

(Standard links)

@civibot civibot bot added the master label Mar 26, 2020
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

This looks fine to me the test failure in unrelated

@seamuslee001 seamuslee001 merged commit 9e1819d into civicrm:master Mar 26, 2020
@seamuslee001 seamuslee001 deleted the acti branch March 26, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001