dev/joomla#26 - Fix path derivation when CMS is rooted in a subdir #16890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- CiviCRM is deployed inside a CMS. The CMS is usually deployed at the HTTP root (`http://example.org`), but it is sometimes deployed in a subdirectory (`http://example.org/my-cms`). Some asset URLs are computed using the variables `[civicrm.bower]`, `[civicrm.packages]`, and `[civicrm.vendor]`, which are derived from the value of `[civicrm.root]`. However, if the site is deployed in a subdirectory, and if using v5.23, then the computation of `[civicrm.bower]` (etc) can misbehave. Before ------ When the URL for `[civicrm.bower]` (or similar) is derived, it goes through multiple filters - first, from absolute to relative, and then later from relative back to absolute. In the process, the base is inadvertently changed. After ----- When the URL is derived, it is computed in absolute format - and simply kept that way. Comments -------- Regarding test coverage, there are two relevant unit-tests. This PR only updates one. * `E2E\Core\PathUrlTest`: This is a more concrete smoke test which demonstrates functional problems with variables like `[civicrm.bower]`. It should already catch problems like dev/joomla#26... but only if you run the E2E suite on a system where the CMS was deployed to a subdirectory. `civibuild` doesn't currently include such a build-type. * `Civi\Core\PathsTest`: This is a more abstract, headless test to examine edge-cases in `Civi\Core\Paths`. It does not specifically check for `[civicrm.bower]` or similar variables (b/c the URL routing is ill-defined in a headless context). However, I've updated it to compare/contrast the working and non-working ways to derive variables.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #16887 from 5.24 RC to 5.23 stable. Add release notes.