Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make api4 select query object more sane #16889

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Make api4 select query object more sane #16889

merged 2 commits into from
Mar 29, 2020

Conversation

colemanw
Copy link
Member

Overview

Refactoring toward adding new features to APIv4. Some cleanup is needed first.

Before

Messier, buggier.

After

Mess cleaned up, bugs fixed, more test coverage.

@civibot
Copy link

civibot bot commented Mar 24, 2020

(Standard links)

@civibot civibot bot added the master label Mar 24, 2020
@colemanw
Copy link
Member Author

test this please

@eileenmcnaughton
Copy link
Contributor

@colemanw test fails relate

@colemanw colemanw changed the title [REF] Make api4 select query object more sane WIP - Make api4 select query object more sane Mar 25, 2020
@colemanw colemanw force-pushed the api4ref branch 2 times, most recently from e0a2060 to 48b12a9 Compare March 27, 2020 02:58
@colemanw colemanw changed the title WIP - Make api4 select query object more sane Make api4 select query object more sane Mar 27, 2020
@eileenmcnaughton
Copy link
Contributor

@colemanw still failing

@colemanw colemanw mentioned this pull request Mar 29, 2020
Merged
@colemanw
Copy link
Member Author

@eileenmcnaughton 👀!

@eileenmcnaughton
Copy link
Contributor

Test cover is good here....

@eileenmcnaughton eileenmcnaughton merged commit f932111 into civicrm:master Mar 29, 2020
@eileenmcnaughton eileenmcnaughton deleted the api4ref branch March 29, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton