Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] BAO_Contact - Remove CRM_Utils_Array::value and other unnecessary code #16874

Merged
merged 1 commit into from
Mar 24, 2020
Merged

[REF] BAO_Contact - Remove CRM_Utils_Array::value and other unnecessary code #16874

merged 1 commit into from
Mar 24, 2020

Conversation

colemanw
Copy link
Member

Overview

Some minor code cleanup in the Contact BAO class.

Before

Messier.

After

Neater.

@civibot
Copy link

civibot bot commented Mar 21, 2020

(Standard links)

@civibot civibot bot added the master label Mar 21, 2020
@colemanw colemanw mentioned this pull request Mar 21, 2020
Merged
@eileenmcnaughton
Copy link
Contributor

@colemanw let's get this merged #16787 before considering this PR - I already had that open to do subsequent cleanup on #16724

@seamuslee001
Copy link
Contributor

@colemanw can you rebase

@colemanw
Copy link
Member Author

retest this pleases

@seamuslee001
Copy link
Contributor

Changes all look consistent and look fine, Jenkins has oked it merging

@seamuslee001 seamuslee001 merged commit 363ce69 into civicrm:master Mar 24, 2020
@colemanw colemanw deleted the contactCleanup branch March 24, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @eileenmcnaughton @seamuslee001