Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv3 - Use new DAO::deleteRecord method #16869

Merged
merged 1 commit into from
Mar 25, 2020
Merged

APIv3 - Use new DAO::deleteRecord method #16869

merged 1 commit into from
Mar 25, 2020

Conversation

colemanw
Copy link
Member

Overview

Followup from #16856 - switches APIv3 to use new generic delete method.

Before

Generic delete code in API layer; redundant with new DAO::deleteRecord.

After

Switch to DAO::deleteRecord and remove redundant code.

Comments

If tests pass this should be good.

@civibot
Copy link

civibot bot commented Mar 20, 2020

(Standard links)

@civibot civibot bot added the master label Mar 20, 2020
@eileenmcnaughton
Copy link
Contributor

Nice - heaps of test cover on this too!

@eileenmcnaughton eileenmcnaughton merged commit 31ecdc7 into civicrm:master Mar 25, 2020
@eileenmcnaughton eileenmcnaughton deleted the del branch March 25, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton