dev/core#1664 - Fix errors recorded in log message on Manage Case scr… #16846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Activity/Page/AJAX.php
Outdated
| @@ -56,7 +56,7 @@ public static function getCaseGlobalRelationships() { | |||
| // get the total row count | |||
| CRM_Case_BAO_Case::getGlobalContacts($globalGroupInfo, NULL, FALSE, TRUE, NULL, NULL); | |||
| // limit the rows | |||
| $relGlobal = CRM_Case_BAO_Case::getGlobalContacts($globalGroupInfo, $params['sortBy'], $showLinks = TRUE, FALSE, $params['offset'], $params['rp']); | |||
| $relGlobal = CRM_Case_BAO_Case::getGlobalContacts($globalGroupInfo, CRM_Utils_Array::value('sortBy', $params), $showLinks = TRUE, FALSE, $params['offset'], $params['rp']); | |||
There was a problem hiding this comment.
Thanks for the PR - I've noticed these messages too. FYI @colemanw might revoke your Civi card if he sees this line. Use $params['sortBy'] ?? NULL
There was a problem hiding this comment.
Thanks @demeritcowboy. Have updated the PR now.
CRM/Case/Page/AJAX.php
Outdated
| @@ -182,7 +182,7 @@ public static function getCases() { | |||
| $params = CRM_Core_Page_AJAX::defaultSortAndPagerParams(); | |||
| $params += CRM_Core_Page_AJAX::validateParams($requiredParameters, $optionalParameters); | |||
|
|
|||
| $allCases = (bool) $params['all']; | |||
| $allCases = (bool) CRM_Utils_Array::value('all', $params, 0); | |||
There was a problem hiding this comment.
$allCases = !empty($params['all']);
|
|
@jitendrapurohit - @colemanw is on the warpath against CRM_Utils_Array::value - if you swap those out this is mergeable based on the review |
…een and case dashboard page
8406fb4 to
1d15448
Compare
|
ah, sorry, wasn't aware of that. Noticed loads of warning on case screen and quickly pushed a PR with the fix. I've updated the changes and removed the usage of Utils_Array now 👍 |
|
Merging based on @demeritcowboy 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…een and case dashboard page
Overview
Various errors recorded in log message on
Before
See gitlab for steps to replicate the issue.
In addition, visiting the case dashboard page records the below error in drupal logs-
After
No error message is recorded.
Comments
Gitlab - https://lab.civicrm.org/dev/core/issues/1664