Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1569: Increase Data Size for form_values column on civicrm_report_instance table #16836

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

tunbola
Copy link
Contributor

@tunbola tunbola commented Mar 18, 2020

Overview

Currently form_values column of the civicrm_report_instance table is of data type TEXT. This is sufficient for saving most report instances. However we have a couple of custom reports based on the Core Civi report functionality with some dynamic filters that may vary based on some conditions in the system. As such some of the reports have a lot of custom form filters fields and when these reports are saved in the database, the serialized data in the form_values column of the civicrm_report_instance table gets truncated and this renders the saved report unusable.

Before

The data type for the form_values column on the civicrm_report_instance is TEXT

After

The data type for the form_values column on the civicrm_report_instance is now LONGTEXT

@civibot
Copy link

civibot bot commented Mar 18, 2020

(Standard links)

@civibot civibot bot added the master label Mar 18, 2020
@eileenmcnaughton
Copy link
Contributor

I think we might need to regenerate the sql too but I'll do that after merge since I think there are some other queued changes that need it

@eileenmcnaughton eileenmcnaughton merged commit 90acd03 into civicrm:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants