Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of mysql field in export table for column with CRM_Utils_Type::T_INT type #16833

Closed
wants to merge 1 commit into from

Conversation

scardinius
Copy link
Contributor

@civibot
Copy link

civibot bot commented Mar 18, 2020

(Standard links)

@civibot civibot bot added the master label Mar 18, 2020
@seamuslee001
Copy link
Contributor

I think this is ok but also kind of feels like its a papering over a bigger issue @eileenmcnaughton any thoughts on the best solution here? Also most of the test fails relate

@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Mar 20, 2020

I commented in gitlab - we have dealt with these through metadata to date & there is handling in the class - obviously not extending to this field - we really really need to replicate in a test before making changes to this class as the table width can break exports

@eileenmcnaughton
Copy link
Contributor

(you can see from the failing tests where the tests are to use as a starting point :-)

@eileenmcnaughton
Copy link
Contributor

I'm closing this as it fails tests - however I have put up an alternate here - #17956 that addresses the issue by improving standardisation. Note that it won't apply cleanly on older versions as I did preliminary cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants