Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove titleHeader var #16816

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes $titleHeader param that is never passed in, and, logically, it would break the csv if it was

Before

 
 public static function writeCSVFile($fileName, $header, $rows, $titleHeader = NULL, $outputHeader = TRUE) {
  • called from 3 places but only 1 passes more than the first 3 params & titleHeader is set to NULL
public static function makeCSVTable($header, $rows, $titleHeader = NULL, $outputHeader = TRUE) {
  • called from 2 places. One is writeCSVFile which only passes NULL for $titleHeader and the other place was passing in NULL

After

public static function writeCSVFile($fileName, $header, $rows, $outputHeader = TRUE) {

 public static function makeCSVTable($header, $rows, $outputHeader = TRUE) {

Technical Details

Minor code cleanup - no impact other than readability

Comments

This is never passed in, and, logically, it would break the csv if it was
@civibot
Copy link

civibot bot commented Mar 17, 2020

(Standard links)

@civibot civibot bot added the master label Mar 17, 2020
@colemanw
Copy link
Member

Makes sense.

@eileenmcnaughton eileenmcnaughton merged commit 48bca06 into civicrm:master Mar 17, 2020
@eileenmcnaughton eileenmcnaughton deleted the ex1 branch June 4, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants