Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of fatal #16759

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

A very long time ago a fatal was added to the code that is not good coding and since it hasn't been hit in 7 years the IRD probably doesn't need it anymore

if (!$contact) {
      // Not dying here is stupid, since we get into weird situation and into a bug that
      // is impossible to figure out for the user or for us
      // CRM-7925
      CRM_Core_Error::fatal();
    }

Before

Code clutter

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Mar 12, 2020

(Standard links)

@civibot civibot bot added the master label Mar 12, 2020
@seamuslee001
Copy link
Contributor

Looks fine to me merging

@seamuslee001 seamuslee001 merged commit 530f7d9 into civicrm:master Mar 13, 2020
@seamuslee001 seamuslee001 deleted the fatal2 branch March 13, 2020 07:38
@agh1
Copy link
Contributor

agh1 commented May 6, 2020

dying is fine)but Death

?o
baby
i

wouldn't like

Death if Death
were
good:for

when(instead of stopping to think)you

begin to feel of it,dying
's miraculous
why?be

cause dying is

perfectly natural;perfectly
putting
it mildly lively(but

Death

is strictly
scientific
& artificial &

evil & legal)

we thank thee
god
almighty for dying
(forgive us,o life!the sin of Death

@eileenmcnaughton
Copy link
Contributor Author

wow that was an unexpected review :-)

@agh1
Copy link
Contributor

agh1 commented May 6, 2020

I figure a little e.e. cummings is always welcome

@eileenmcnaughton
Copy link
Contributor Author

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants