Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Test cleanup, remove duplicate test #16755

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

It turns out the removed test is identical to testEntityTagDeleteINDHH earlier in the class

  • probably consolidation of the functions called led to this

Before

2 tests have exactly the same code

After

poof

Technical Details

Comments

It turns out the removed test is identical to testEntityTagDeleteINDHH earlier in the class
- probably consolidation of the functions called led to this
@civibot
Copy link

civibot bot commented Mar 12, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

@eileenmcnaughton which is the test that matches the one your removing, the delete parameters look a bit different to the other tests around it

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 testEntityTagDeleteINDHH per ^^

@colemanw
Copy link
Member

I confirm it's identical.

@colemanw colemanw merged commit 9e1d75a into civicrm:master Mar 16, 2020
@colemanw colemanw deleted the et branch March 16, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants