Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Hopefully fix regularly failing conformance test #16732

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Mar 10, 2020

There's still an unanswered question but here's my thinking:

The line I've changed is passing $processor to a function, however it is the UNMODIFIED version of the variable from the foreach iterator NOT the one that gets updated during the loop before being passed on, so it might not have user_name in it. But note for subsequent callers of the getAllPaymentProcessors function it will use the modified one from the cache and not even call the failing line.

Let's see what happens...

@civibot
Copy link

civibot bot commented Mar 10, 2020

(Standard links)

@civibot civibot bot added the master label Mar 10, 2020
@colemanw
Copy link
Member

Nice! Thanks, that flaky test was super annoying!

@colemanw colemanw merged commit f75168a into civicrm:master Mar 10, 2020
@demeritcowboy
Copy link
Contributor Author

Fingers crossed!

@demeritcowboy demeritcowboy deleted the conformance branch March 10, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants