[REF] Hopefully fix regularly failing conformance test #16732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still an unanswered question but here's my thinking:
The line I've changed is passing $processor to a function, however it is the UNMODIFIED version of the variable from the foreach iterator NOT the one that gets updated during the loop before being passed on, so it might not have
user_name
in it. But note for subsequent callers of the getAllPaymentProcessors function it will use the modified one from the cache and not even call the failing line.Let's see what happens...