Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Use empty() instead of CRM_Utils_Array::value() in inline conditionals #16729

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 9, 2020

Overview

This is part of a series of PRs to update an old code pattern. CRM_Utils_Array::value() can in many cases be swapped for empty or the ?? operator.

Comments

This PR targets inline conditionals. Before/after should be functionally identical.

@civibot
Copy link

civibot bot commented Mar 9, 2020

(Standard links)

@civibot civibot bot added the master label Mar 9, 2020
@eileenmcnaughton
Copy link
Contributor

test fails unrelated - these are remarkably hard to review because I glaze over after about half a dozen lines & then I realise I have to go back & start again - I must be some sort of gold fish. Any way I got through these ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants