Fix another instance of silly use of CRM_Utils_Array::value

[eileenmcnaughton]

Overview

Removes another place where a non array is sometimes passed to CRM_Utils_Array::value

Before

Values passed to include CRM_Utils_Array::value as the array include strings & integers

After

It the value is a string CRM_Utils_Array::value would return the default - of 0 - so !is_array($result) is equivalent to $result['is_error'] = 0. It could also be a getsingle result so the absence of is_error as a key also indicates success

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Tests have passed and if there was an issue i'm sure our chained api tests would have failed merging

[colemanw]

Err, well this change does capture the literal meaning of what CRM_Utils_Array::value does, but when you look at it this way it doesn't quite make sense. You can't perform api chaining without an array of results! See follow-up #16718