Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing a non-array to CRM_Utils_Array::value #16701

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

As surfaced in https://test.civicrm.org/job/CiviCRM-Core-PR/32543/console when we tested deprecating
passing in a non-array

Before

Passes in a non-array

After

Ensures it is an array

Technical Details

I didn't clean up the second instance - I thought about empty() but wasn't sure it if could be 0 - just wanted to keep scope minimal for this

Comments

@civibot
Copy link

civibot bot commented Mar 6, 2020

(Standard links)

@civibot civibot bot added the master label Mar 6, 2020
@seamuslee001
Copy link
Contributor

@eileenmcnaughton build process is giving off Illegal offset type Menu.php:233 [warning] Illegal offset type Menu.php:230 [warning] Illegal offset type Menu.php:230 [warning] Illegal offset type Menu.php:230 [warning] Illegal offset type Menu.php:233 [warning] Illegal offset type Menu.php:230 [warning] Illegal offset type Menu.php:230 [warning] Illegal offset type Menu.php:230 [warning] Sorry. A non-recoverable error has occurred. 'civicrm/dashboard': Could not find page_arguments in path tree, Could not find is_ssl in path tree

@eileenmcnaughton
Copy link
Contributor Author

interesting = no idea what horrible thing is't doing - I've seen that error on my dev sites in the past too

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I stepped through it in CRM_Core_MenuTest & this seems right now

@colemanw
Copy link
Member

colemanw commented Mar 7, 2020

Unrelated fail

@colemanw colemanw merged commit df52fb7 into civicrm:master Mar 7, 2020
@colemanw colemanw deleted the array2 branch March 7, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants