Support PropertyBag in CRM_Utils_Array #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Mar 6, 2020
|
Hmm - looks like Core_menu needs to case to an array |
|
Retest this please |
|
@eileenmcnaughton checking the console output, this appears to have triggered the deprecation notice 32 times. |
|
test this please |
|
test this please |
1 similar comment
|
test this please |
We now use the PropertyBag in payment processors - but as @mattwire discovered the CRM_Utils_Array::value function is commonly used to access values now potentially 'in the bag' and the 'is_array' filtering here means it is not being returned
|
@colemanw I've pulled out the attempt to deprecate passing in non-arrays. It became clear it wasn't just a few outliers that were doing that & it was getting into a silly scope situation |
|
@colemanw @eileenmcnaughton Small follow-up PR #16737 so that array value still works on array access objects in the same way as it does for arrays. |
colemanw
added a commit
that referenced
this pull request
Mar 10, 2020
…ollowup CRM_Utils_Array::values follow up from #16699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We now use the PropertyBag in payment processors - but as @mattwire discovered the CRM_Utils_Array::value
function is commonly used to access values now potentially 'in the bag' and the 'is_array'
filtering here means it is not being returned
Before
Support PropertyBag in CRM_Utils_Array::value does not return values from the PropertyBag
After
Values returned - note we will encourage devs to move to direct access
Technical Details
Comments
discussion https://chat.civicrm.org/civicrm/pl/aygaho49jff5tqgar9erow7dew