Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dbAlias to generate where clause for date field in activity report #16689

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

pradpnayak
Copy link
Contributor

Overview

Use db alias when generating where clause for date field over field name else it will result in "Column 'activity_date_time' in where clause is ambiguous" error if we want to join activity table again to the report using hook.

Before

WHERE ( activity_date_time >= 20200301000000 ) AND ( activity_date_time <= 20200307235959 )

After

WHERE ( activity_civireport.activity_date_time >= 20200301000000 ) AND ( activity_civireport.activity_date_time <= 20200307235959 )

@civibot
Copy link

civibot bot commented Mar 5, 2020

(Standard links)

@civibot civibot bot added the master label Mar 5, 2020
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

@seamuslee001 seamuslee001 merged commit c8ebc62 into civicrm:master Mar 6, 2020
@pradpnayak
Copy link
Contributor Author

Thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants