Use dbAlias to generate where clause for date field in activity report #16689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use db alias when generating where clause for date field over field name else it will result in "Column 'activity_date_time' in where clause is ambiguous" error if we want to join activity table again to the report using hook.
Before
WHERE ( activity_date_time >= 20200301000000 ) AND ( activity_date_time <= 20200307235959 )
After
WHERE ( activity_civireport.activity_date_time >= 20200301000000 ) AND ( activity_civireport.activity_date_time <= 20200307235959 )