[REF] simplify references to civicrm_acl #16671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can see looking at ACL.xml that civicm_acl can't be localised so we gain nothing by using a varible. Also note that we want to switch to CRM_Core_Execute::query in these functions so that table translation is handled by that function - this is old code done the old way. However, the thing I'm trying to unravel is if & where the values for the fields entity_table & object_table are localised. We have been switching AWAY from saving localised table names & TBH I think we maybe don't & it's a lot of cruft for some ideas that never eventuated but I'm still digging
|
(Standard links)
|
eileenmcnaughton
commented
Mar 2, 2020
| @@ -160,11 +160,10 @@ protected static function getACLs(int $contact_id) { | |||
|
|
|||
| $rule = new CRM_ACL_BAO_ACL(); | |||
|
|
|||
| $acl = self::getTableName(); | |||
| $contact = CRM_Contact_BAO_Contact::getTableName(); | |||
|
|
|||
| $query = " SELECT acl.* | |||
There was a problem hiding this comment.
@seamuslee001 I've been digging on this - I can't find any evidence that anywhere in core ever saves to civicrm_acl with the value entity_table = 'contact'
It seems the OG bridge has some hard coding to acl_role
|
Changes i think are ok merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
A variable used in mysql to stand in for civicrm_acl
After
civicrm_acl is used - no change in functionality - ACLS still work (& we have test cover on that)
Technical Details
We can see looking at ACL.xml that civicm_acl can't be localised so we gain nothing
by using a varible.
Also note that we want to switch to CRM_Core_Execute::query in these functions so
that table translation is handled by that function - this is old code done the old way.
However, the thing I'm trying to unravel is if & where the values for the fields
entity_table & object_table are localised. We have been switching AWAY from
saving localised table names & TBH I think we maybe don't & it's a lot of cruft
for some ideas that never eventuated but I'm still digging
Comments