Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Only call getACLs when contact_id is present, remove handling #16667

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup

Before

getACLs called regardless if $contact_id is NULL, handling in the function for it being null or not an integer

After

getACLs only called if contact_id is not null, cast to an int

Technical Details

getACLs is called from one place in the code. Within the function there are 2 places that
handle the possibility it might be null - this moves it to the calling function
& requires contact id to be an int

Comments

getACLs is called from one place in the code. Within the function there are 2 places that
handle the possibility it might be null - this moves it to the calling function
& requires contact id to be an int
@civibot
Copy link

civibot bot commented Mar 2, 2020

(Standard links)

@civibot civibot bot added the master label Mar 2, 2020
@colemanw colemanw merged commit 9ae5612 into civicrm:master Mar 2, 2020
@colemanw colemanw deleted the acl branch March 2, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants