dev/core#1613/Updated Misleading labels

[kartik1000]

Signed-off-by: Kartik Kathuria kathuriakartik0@gmail.com

Overview

Update the misleading labels on public Contribution and Registration forms, as mentioned in dev/core#1613 . Changed 'confirm payment' to 'Review your contribution' on contribution form and 'continue' on registration page to 'Review your registration' .

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@kartik1000 can you fix the indent issue here?

[kartik1000]

Yes, sure. 5 mins.

[kartik1000]

@seamuslee001, I have fixed it.

[yashodha]

test this please

[colemanw]

@civibot test this please

[kartik1000]

@colemanw are there any issues?

[yashodha]

@kartik1000 test failure looks unrelated. In general we always try to make sure the tests pass before we merge the PR

[yashodha]

test this please

[kartik1000]

Ok @yashodha.

[kartik1000]

@yashodha @colemanw What can we do to make sure the tests pass. Probably go back to the merge from where it's causing the error?

[demeritcowboy]

@kartik1000 The test that is failing (if you click the details link on the right-hand side where it says the checks have failed) is a common false-positive (see https://lab.civicrm.org/dev/core/-/wikis/Testy-tests), so you don't need to do anything about that. But there is a second problem where it says "This branch has conflicts". You need to rebase your branch - see https://docs.civicrm.org/dev/en/latest/tools/git/#rebasing and the section below it.

[kartik1000]

Ok @demeritcowboy, I will rebase. So do you feel that if we might run the tests again, these tests might pass then?

[demeritcowboy]

Right. When you push your rebased branch jenkins here will automatically restart the tests.

[kartik1000]

@demeritcowboy, Consequently you were right, all tests have passed!

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
    • In the lab ticket there's a lot of agreement about this change.
    • Just for the record: Since the new string isn't already translated elsewhere the button will now start appearing in english on non-english sites until it gets retranslated, but also as noted in the ticket using Word Replacement should work well for this new string. Ditto it will break existing use of Word Replacements, so people will need to update theirs.
  • [r-doc] PASS
  • [r-run] PASS
    • Did a very light run on the test site here since this is just a text change. Works.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] N/A
  • [r-test] PASS

[mattwire]

Thanks @kartik1000 merging based on @demeritcowboy review