APIv4 - Correctly return null values from DAO save actions #16645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make sure the value "null" is not returned as a string
Don't return null values from saved DAO objects unless it is in params or reload is set to true
Before
Some weirdness was coming back from APIv4 Create/Update/Save actions.
null
values were sometimes the string "null" (which is a workaround at the DB layer we don't want bleeding into the api).It would also return some misleading data during update operations, returning
null
for fields which may not be null in the db but were not set in the update.After
Ensures
null
is not returned as a string.Ensures unknown values are not returned at all from update ops instead of being returned as
null
.Technical Details
Test added.