dev/core#1615 - Fix for recently migrated civicrm-setup #16621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- Fix a recent (intra-alpha) regression from civicrm#16618 The search for `civicrm-setup` goes slightly awry because the migrated copy of civicrm-setup uses the core's classloader rather than its own classloader. Steps to Reproduce ------------------ * Create a site with WP and Civi(master). * Ensure Civi is uninstalled. (ex: `cv core:uninstall -f`) * In `wp-content/plugins/civicrm/civicrm`, touch the file `.use-civicrm-setup`. (*This is supposed to activate the new UI.*) * Go to the WP admin console. In the left navbar, choose "CiviCRM Installer". Before ------ It fails to load the new UI -- the search finds `.use-civicrm-setup` but does not find `civicrm-setup-autoload.php`. It falls back to the old UI. After ----- It opens the new UI.
|
(Standard links)
|
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a recent (intra-alpha) regression from #16618
The search for
civicrm-setupgoes slightly awry because the migrated copy of civicrm-setup uses the core's classloader rather than its own classloader.Steps to Reproduce
cv core:uninstall -f)wp-content/plugins/civicrm/civicrm, touch the file.use-civicrm-setup.(This is supposed to activate the new UI.)
Before
It fails to load the new UI -- the search finds
.use-civicrm-setupbut does not findcivicrm-setup-autoload.php. It falls back to the old UI.After
It opens the new UI.