Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use col "Soft Credit Amount Stats" and any filter of contribution… #16591

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

CsarRamos
Copy link
Contributor

Overview

When try to use report contribution summary with col "Soft Credit Amount Stats" and add any filter of contribution stats ex: Cotribution Count "total_count_value" the report show error: "DB Error: no such field"

Before

You cannot use the contribution filters stats with the "Soft Credit Amount Stats" column

After

You use all stats with all filters

Technical Details

Fixed needed columns when use this fields

Comments

issue: https://lab.civicrm.org/dev/core/issues/1575

@civibot
Copy link

civibot bot commented Feb 19, 2020

(Standard links)

@civibot civibot bot added the master label Feb 19, 2020
@mlutfy
Copy link
Member

mlutfy commented Mar 16, 2020

jenkins, test this please

@mlutfy
Copy link
Member

mlutfy commented Mar 16, 2020

@agh1 Is this something you could review? (I think you have worked on this issue before?)

@jaapjansma
Copy link
Contributor

test this please

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: We tested this in dmaster and in the test environment of this PR. In dmaster we get an error and with this PR it works.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results have failures, but these have been individually inspected and found to be irrelevant.

@eileenmcnaughton or @mattwire could one of you merge this PR?

@seamuslee001
Copy link
Contributor

Merging as per the review

@seamuslee001 seamuslee001 merged commit 8abebe2 into civicrm:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants