Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice #16585

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add deprecation notice #16585

merged 1 commit into from
Feb 18, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

I've been trying to figure out when this line would be hit but I just can't find a way to trigger
it - removing it would help a lot with this code but let's deprecate for a bit.

Before

LIne not hit as far as I can tell - $params['priceSetId'] has no way of being populated

After

Notice it it were to be hit

Technical Details

This code hasn't been touched for a while & lots has changed without stuff being cleaned up + functions that used to be shared are no longer so there seems to be a lot of unused stuff

Comments

I've been trying to figure out when this line would be hit but I just can't find a way to trigger
it - removing it would help a lot with this code but let's deprecate for a bit.
@civibot
Copy link

civibot bot commented Feb 18, 2020

(Standard links)

@civibot civibot bot added the master label Feb 18, 2020
@yashodha
Copy link
Contributor

@eileenmcnaughton can be merged.

@yashodha yashodha merged commit 2598dea into civicrm:master Feb 18, 2020
@eileenmcnaughton eileenmcnaughton deleted the dep_it branch February 18, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants