(NFC) Fix typo - no hyphen in 'override'

[wmortada]

Overview

Very minor change to fix a typo. There is no hyphen in the word 'override'.

Before

Incorrect spelling: 'over-ride'

After

Correct spelling: 'override'.

Technical Details

None.

Comments

None.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I'm not trying to block this and obviously technically it's correct and this makes it look more professional, but this is a good example of what I was trying to get clarification on in https://github.com/civicrm/civicrm-dev-docs/pull/754/files. When does the benefit outweigh the downside of having to retranslate this string in all languages which can take a couple release cycles during which time it goes back to being untranslated. I don't know the exact answer - maybe spelling mistakes should always be fixed all the time, as opposed to when it's something more technical. If so, it would be good to get that clarification.

[eileenmcnaughton]

That's a tough one @demeritcowboy - I've understood it to be 'change it once & change it right'

For now I'm merging this - even though I kinda like the hyphen I accept google didn't support me in that

[demeritcowboy]

Ok I'll see if I can add something to the docs PR.

[wmortada]

@eileenmcnaughton thanks for merging

@demeritcowboy I think you raise a good point here and it would be good to clarify best practice. My inclination would be to fix spelling mistakes (particularly when it is inconsistent on the same page as in this case). However, I don't think I fully appreciate the impact that this has on the translations so it is certainly helpful to be mindful of this.

In this particular case is there a way of keeping the translations as they are currently? i.e. could the translation strings be copied so that the existing translations apply to this slightly modified string? (Apologies for my ignorance about how the translation system works.)

[demeritcowboy]

It's an interesting thought about keeping the current translations/copying them over, but it's hard to say when you do and don't want that. For example the particular string in this PR is also spelled wrong in some translations, e.g. en_GB (https://lab.civicrm.org/dev/translation/blob/master/po/en_GB/member.po#L1627), so you don't want to keep it.

The process is described at https://lab.civicrm.org/dev/translation/-/wikis/Pushing-new-strings-to-transifex and related documents on that wiki https://lab.civicrm.org/dev/translation/-/wikis/home. But a complication is that it's not fully automated because some of it needs to be manually weeded by someone - see the 3rd paragraph in the description at https://lab.civicrm.org/infra/ops/issues/931. So anyway if you're curious those are some docs to read.

[wmortada]

Good point!
Thanks for the links. Helpful to understand how the process works.