Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helper function now that contribution settings is not weirdly stored #16566

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup - now the setting is stored properly we just need setting::get to retrieve it

Before

Helper function to get the setting from a non-std array

After

Since the setting is no longer non-std we can just use setting.get

Technical Details

This is the only place that accesses this function / setting - it's as if it were defined properly all along
now - it was all just a dream.

Comments

…stored

This is the only place that accesses this function / setting - it's as if it were defined properly all along
now - it was all just a dream.
@civibot
Copy link

civibot bot commented Feb 17, 2020

(Standard links)

@civibot civibot bot added the master label Feb 17, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit f11c4d9 into civicrm:master Mar 2, 2020
@colemanw colemanw deleted the setting_fix branch March 2, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants