Remove helper function now that contribution settings is not weirdly stored #16566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup - now the setting is stored properly we just need setting::get to retrieve it
Before
Helper function to get the setting from a non-std array
After
Since the setting is no longer non-std we can just use setting.get
Technical Details
This is the only place that accesses this function / setting - it's as if it were defined properly all along
now - it was all just a dream.
Comments