Do not fatally fail on angular pages if an extension is missing #16533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an extension is missing trying to create a new mailing will totally fail - on QF pages we just get a not-very-clear message
|
(Standard links)
|
| $urls[$module->name] = $this->keyToUrl($module->name); | ||
| } | ||
| catch (CRM_Extension_Exception_MissingException $e) { | ||
| CRM_Core_Session::setStatus(ts('An enabled extension is missing from the extensions directory') . ':' . $module->name); |
There was a problem hiding this comment.
this doesn't seem to bubble up - but I think it's clearer keeping it in
|
test this please |
|
I checked out #15011 & I think this could be reasonably seen as a reviewer's commit of that since I reached all the same conclusions |
|
test this please |
|
Merging as a reviewer's commit as this is the same (other than code comments) as #15011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If an extension is missing trying to create a new mailing will totally fail - on QF pages we just get a
not-very-clear message - now we have parity
Before
After
Technical Details
Comments
@MegaphoneJon I feel we've discussed this before