Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1498 Include hook_civicrm_managed into the list of upgrade f… #16521

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

seamuslee001
Copy link
Contributor

…reindly hooks

Overview

This aims to try to resolve the issue with managed entities by including the hook_civicrm_managed in the list of upgrade safe entities

Before

Managed Entities process may try to remove entities in post upgrade

After

Managed Entities should reconcile correctly

ping @eileenmcnaughton @totten

@civibot
Copy link

civibot bot commented Feb 13, 2020

(Standard links)

@civibot civibot bot added the 5.23 label Feb 13, 2020
@eileenmcnaughton
Copy link
Contributor

I agree with this change - but I was under the impression we already merged one like this?

@eileenmcnaughton
Copy link
Contributor

oh no - we merged a change to make it not reconcile until after it had a chance to load - that is probably the right way - but why didn't it work?

@eileenmcnaughton eileenmcnaughton merged commit fb3f698 into civicrm:5.23 Feb 13, 2020
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 given the symptoms this is probably better merged

@eileenmcnaughton eileenmcnaughton deleted the dev_core_1489_2 branch February 13, 2020 21:50
@totten totten changed the title dev/core#1489 Include hook_civicrm_managed into the list of upgrade f… dev/core#1498 Include hook_civicrm_managed into the list of upgrade f… Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants