-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIv4 - merge ActionUtil with Request::create #16516
Conversation
The Request::create function was broken for v4, and ActionUtil had been serving the same purpose but in a non-broken way.
(Standard links)
|
Retest this please |
@colemanw the test rig is getting tied up on the test suite.
|
@seamuslee001 looks like that was an uncaught exception caused by |
@colemanw test failures look related |
@colemanw latest test failures look related |
@seamuslee001 I got the tests passing by cleaning up all the places where the api wrapper was being used incorrectly, e.g. with missing |
Looks like our test cover is working well here - merging now they are passing |
Overview
Consolidates some APIv4 code with v3.
Before
The
Request::create
function was broken for v4, andActionUtil
had been serving the same purpose but in a non-broken way.After
Deleted
ActionUtil
and fixedRequest::create
to work correctly with v4.